Skip to content

chore(secretmanager): Added code samples for delayed destroy #2148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore(secretmanager): Added code samples for delayed destroy #2148

wants to merge 4 commits into from

Conversation

durgesh-ninave-crest
Copy link
Contributor

Description

Created samples for Global and Regional Secret Manager API

Samples (Global, Regional)

  1. Create Secret With Delayed Destroy
  2. Disable Secret Delayed Destroy
  3. Update Secret With Delayed Destroy

Checklist

  • I have followed guidelines from the CONTRIBUTING.MD
  • Appropriate changes to README are included in PR
  • Test passed: ../testing/vendor/bin/phpunit test/ -v
  • Lint passed: php-cs-fixer fix . --config .php-cs-fixer.dist.php
  • These samples need a new API enabled in testing projects to pass (let us know which ones)

Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added api: secretmanager Issues related to the Secret Manager API. samples Issues that are directly related to samples. labels Jul 22, 2025
YashSaraf11
YashSaraf11 requested changes Jul 25, 2025
View reviewed changes
Copy link

@YashSaraf11 YashSaraf11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please assert in the test scenarios that the delayed destory was disabled or updated. I do not see any assert statements on those tests for the operation verification.

@durgesh-ninave-crest
Copy link
Contributor Author

Please assert in the test scenarios that the delayed destory was disabled or updated. I do not see any assert statements on those tests for the operation verification.

I've updated the assertion to reflect the intended functionality of the sample.

@durgesh-ninave-crest durgesh-ninave-crest marked this pull request as ready for review August 5, 2025 05:19
@durgesh-ninave-crest durgesh-ninave-crest requested review from a team as code owners August 5, 2025 05:19
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Aug 5, 2025

Here is the summary of changes.

You are about to add 6 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YashSaraf11 YashSaraf11 YashSaraf11 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
api: secretmanager Issues related to the Secret Manager API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@durgesh-ninave-crest @YashSaraf11